From 9576bb830e3bc359e9ec98692ca949bc4a04d59e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”>
Date: Wed, 17 Apr 2024 15:35:40 +0530
Subject: [PATCH] fix: show linting errors on browser API added

---
 .../e2e/Regression/ClientSide/Linting/BasicLint_spec.ts    | 7 ++++++-
 app/client/src/plugins/Linting/constants.ts                | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/client/cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
index 864f4ee7b9ec..4331996e14fa 100644
--- a/app/client/cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
+++ b/app/client/cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
@@ -67,8 +67,13 @@ describe("Linting", { tags: ["@tag.JS"] }, () => {
     AppSidebar.navigate(AppSidebarButton.Editor);
   });
 
-  it("1. TC 1927 - Shows correct lint error when Api is deleted or created", () => {
+  it("1. TC 1927 - Show correct lint errors", () => {
+    // For browser APIs it should give linting error
     EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
+    propPane.EnterJSContext("onClick", `{{window}}`);
+    agHelper.AssertElementExist(locators._lintErrorElement);
+
+    // Shows correct lint error when Api is deleted or created
     propPane.EnterJSContext(
       "onClick",
       `{{function(){
diff --git a/app/client/src/plugins/Linting/constants.ts b/app/client/src/plugins/Linting/constants.ts
index 5c04ff6e2424..506fe6f567a5 100644
--- a/app/client/src/plugins/Linting/constants.ts
+++ b/app/client/src/plugins/Linting/constants.ts
@@ -21,7 +21,7 @@ export const lintOptions = (globalData: Record<string, boolean>) =>
     sub: true, // Don't force dot notation
     expr: true, // suppresses warnings about the use of expressions where normally you would expect to see assignments or function calls
     // environments
-    browser: true,
+    browser: false,
     worker: true,
     mocha: false,
     // global values