Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): inconsistency between Security Policy and Contributing Guide #765

Merged
merged 4 commits into from
Mar 5, 2023

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Mar 5, 2023

Type of Change:

修正(ドキュメント)

Details of implementation (実施内容)

Security Policy と Contributing Guide ともに記述されている セキュリティーに関する不具合の報告 にて2つの間に齟齬が見られているので修正しました。


修正した齟齬

  • Contributing Guide 側には GitHub Security Advisories からの報告方法が書いてあるが、 Security Policy 側には記述がない

@m1sk9 m1sk9 added the C-development Category: development label Mar 5, 2023
@m1sk9 m1sk9 requested a review from MikuroXina March 5, 2023 08:14
@m1sk9 m1sk9 self-assigned this Mar 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Merging #765 (c5e1252) into main (c582be2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files          72       72           
  Lines        4889     4889           
  Branches      472      472           
=======================================
  Hits         3550     3550           
  Misses        868      868           
  Partials      471      471           
Flag Coverage Δ
unittests 72.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SECURITY.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正前のように, このレポジトリで Advisory を作成するためのリンクがあってもよいかと

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@m1sk9 m1sk9 merged commit 33c4908 into main Mar 5, 2023
@m1sk9 m1sk9 deleted the docs/fix-inconsistency-security-policy branch March 5, 2023 09:14
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-development Category: development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants