fix: sendEphemeralToSameChannel でのメンションを抑制 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sk9
approved these changes
Feb 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 72.87% 72.79% -0.08%
==========================================
Files 70 70
Lines 4814 4819 +5
Branches 455 455
==========================================
Hits 3508 3508
- Misses 854 859 +5
Partials 452 452
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change:
コードの改善
Details of implementation (実施内容)
一時的にしか表示されないメッセージを送信する
sendEphemeralToSameChannelメソッドでユーザーにメンションが入るのは不自然なので, 該当する文字列があってもメンションされないようにallowedMentionsを指定しました.