Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Memeのヘルプに使われる説明欄の修正 #670

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Jan 14, 2023

Type of Change:

修正

Details of implementation (実施内容)

--help フラグで表示されるヘルプの説明欄がヘルプに値しないミームがあったため、書き直しました。

@m1sk9 m1sk9 requested a review from MikuroXina January 14, 2023 08:35
@m1sk9 m1sk9 self-assigned this Jan 14, 2023
@m1sk9 m1sk9 enabled auto-merge (squash) January 14, 2023 08:36
@codecov-commenter
Copy link

Codecov Report

Merging #670 (374be63) into main (13c5bc2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   71.77%   71.78%   +0.01%     
==========================================
  Files          66       66              
  Lines        4659     4661       +2     
  Branches      438      438              
==========================================
+ Hits         3344     3346       +2     
  Misses        880      880              
  Partials      435      435              
Flag Coverage Δ
unittests 71.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/command/meme/hukueki.ts 83.33% <100.00%> (ø)
src/service/command/meme/kenjou.ts 85.71% <100.00%> (ø)
src/service/command/meme/koume.ts 87.50% <100.00%> (ø)
src/service/command/meme/moeta.ts 86.66% <100.00%> (+2.05%) ⬆️
src/service/command/meme/takopi.ts 83.33% <100.00%> (ø)
src/service/command/meme/web3.ts 84.61% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

妥当な改善かどうか怪しいけど, まぁ問題はないので

@m1sk9 m1sk9 merged commit 5802e0d into main Jan 14, 2023
@m1sk9 m1sk9 deleted the fix/meme-help branch January 14, 2023 09:10
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants