feat(meme): 短いオプションのキーが使えるように #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 73.84% 73.86% +0.02%
==========================================
Files 63 63
Lines 4531 4535 +4
Branches 401 402 +1
==========================================
+ Hits 3346 3350 +4
Misses 785 785
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raiga0310
added a commit
that referenced
this pull request
Nov 26, 2022
* feat: オプションの追加 * オプション追加実装に伴うテストケースの追加 * chore: テストの引数の変更 * refactor: オプション引数への再設計( #586 対応待ち ) * fix: オプションの設定もれの修正 * chore: テストケースの修正 * chore: deletion comment Co-authored-by: Mikuroさいな <ryosukadnak@gmail.com> * fix: テストケースの追加 修正 * refactor: オプション・フラグの重複時への対応 * feat: 引数不足時のテストケースの追加 * chore: ヘルプメッセージの親切化 Co-authored-by: m2en <me@m2en.dev> Co-authored-by: Mikuroさいな <ryosukadnak@gmail.com> Co-authored-by: m2en <me@m2en.dev>
This was referenced Nov 28, 2022
This was referenced Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change:
Meme の機能追加
Details of implementation (実施内容)
MemeTemplateのoptionsKeysにcなどの一文字だけを使ったりflagsKeysにverboseなどの 2 文字以上の文字列を指定しても正しく動作するようになりました.Additional Information (追加情報)
#585 をより簡潔にするための機能です. なるべく早くレビューが欲しいです.