Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 同じメッセージが編集されたかどうかのチェックを追加 #447

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

MikuroXina
Copy link
Collaborator

@MikuroXina MikuroXina commented Sep 3, 2022

Type of Change:

バグ修正のための機能追加

Details of implementation (実施内容)

バグの再現性があまり無いため, とりあえず応急処置的な対策をしてみました.

@MikuroXina MikuroXina enabled auto-merge (squash) September 3, 2022 13:45
@MikuroXina MikuroXina self-assigned this Sep 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #447 (dad1bf5) into main (8f8b226) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head dad1bf5 differs from pull request most recent head f375996. Consider uploading reports for the commit f375996 to get more accurate results

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   71.37%   71.32%   -0.05%     
==========================================
  Files          58       58              
  Lines        3933     3944      +11     
  Branches      369      369              
==========================================
+ Hits         2807     2813       +6     
- Misses        757      762       +5     
  Partials      369      369              
Flag Coverage Δ
unittests 71.32% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/adaptor/proxy/middleware.ts 73.58% <50.00%> (-4.99%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストとかは追加しないん?

@MikuroXina
Copy link
Collaborator Author

@m2en こちらはアダプタの実装なので, 実際に実行してみる以外にテストできないかと思います. 一応, 報告されたケースで改善されたことは確認できました.

@MikuroXina MikuroXina enabled auto-merge (squash) September 3, 2022 16:18
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants