Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ギルド情報参照コマンドの追加 #392

Merged
merged 16 commits into from
Aug 10, 2022
Merged

feat: ギルド情報参照コマンドの追加 #392

merged 16 commits into from
Aug 10, 2022

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Aug 10, 2022

close #382
close #317

Type of Change:

新規追加

Details of implementation (実施内容)

!guildinfo / !serverinfo で環境変数で定義されているギルドIDのギルドの情報を表示します。

@m1sk9 m1sk9 requested a review from MikuroXina August 10, 2022 10:01
@m1sk9 m1sk9 self-assigned this Aug 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #392 (2470711) into main (6017339) will decrease coverage by 0.02%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   69.89%   69.86%   -0.03%     
==========================================
  Files          55       56       +1     
  Lines        3644     3644              
  Branches      351      352       +1     
==========================================
- Hits         2547     2546       -1     
  Misses        746      746              
- Partials      351      352       +1     
Flag Coverage Δ
unittests 69.86% <46.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/model/create-timestamp.ts 25.00% <25.00%> (ø)
src/service/command/user-info.ts 85.71% <80.00%> (+2.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m1sk9 m1sk9 marked this pull request as ready for review August 10, 2022 12:32
@m1sk9 m1sk9 enabled auto-merge (squash) August 10, 2022 12:32
@m1sk9 m1sk9 disabled auto-merge August 10, 2022 12:33
@m1sk9 m1sk9 changed the title WIP) feat: ギルド情報参照コマンドの追加 feat: ギルド情報参照コマンドの追加 Aug 10, 2022
@m1sk9 m1sk9 enabled auto-merge (squash) August 10, 2022 12:33
src/adaptor/discord/member-stats.ts Outdated Show resolved Hide resolved
src/adaptor/discord/member-stats.ts Outdated Show resolved Hide resolved
src/service/command/guild-info.ts Outdated Show resolved Hide resolved
src/service/command/guild-info.ts Outdated Show resolved Hide resolved
src/service/command/guild-info.ts Outdated Show resolved Hide resolved
src/service/command/guild-info.ts Outdated Show resolved Hide resolved
meru and others added 6 commits August 10, 2022 21:40
Co-authored-by: Mikuroさいな <ryosukadnak@gmail.com>
Co-authored-by: Mikuroさいな <ryosukadnak@gmail.com>
Co-authored-by: Mikuroさいな <ryosukadnak@gmail.com>
src/service/command/guild-info.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@MikuroXina MikuroXina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストの追加もお願いします

@m1sk9 m1sk9 merged commit 83cbf70 into main Aug 10, 2022
@m1sk9 m1sk9 deleted the feat/guildinfo branch August 10, 2022 15:10
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

!serverinfo - サーバーの情報を表示する feat: 情報参照系のコマンドを追加する
3 participants