Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate config fields after applying rules #66

Open
hinerm opened this issue Dec 17, 2024 · 1 comment
Open

De-duplicate config fields after applying rules #66

hinerm opened this issue Dec 17, 2024 · 1 comment

Comments

@hinerm
Copy link
Collaborator

hinerm commented Dec 17, 2024

In 9ee3bbb I updated the plus function to distinct most lists.

However, this happens before applying conditional rules to the config, after which there may be more fields in need of de-duplication. We should check, in particular, if it's possible to end up with multiple JVM search locations.

Any fix may be appropriate for #39 as well

@ctrueden
Copy link
Member

I took a quick peek, and see that the python and jvm root path logic each converts their respective directory list into a set via toSet() before scanning, so we're effectively already deduplicating those.

@ctrueden ctrueden reopened this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants