Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Bug: Wrong versioning in DLLs #18

Closed
applejag opened this issue Dec 1, 2019 · 0 comments · Fixed by #21
Closed

Bug: Wrong versioning in DLLs #18

applejag opened this issue Dec 1, 2019 · 0 comments · Fixed by #21
Assignees
Labels
bug Something isn't working

Comments

@applejag
Copy link
Owner

applejag commented Dec 1, 2019

Local news says that the official Newtonsoft.Json only contains the major version in the AssemblyVersion...

Taken directly from Build/build.ps1 script inside source Newtonsoft.Json repo:

function NetCliBuild()
{
  /.../

  $assemblyVersion = $majorVersion + '.0.0'

  # omitted most parameters
  exec { & $script:msBuildPath "/t:build" /.../ "/p:AssemblyVersion=$assemblyVersion" "/p:FileVersion=$version" "/m" }
}

Expected behavior

Assembly version for 12.0.101 release is 12.0.0.0

Actual behavior

Assembly version for 12.0.101 release is 12.0.1.0

@applejag applejag added the bug Something isn't working label Dec 1, 2019
@applejag applejag self-assigned this Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant