-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement convenience factory methods for Async[Throwing]Stream #62968
Implement convenience factory methods for Async[Throwing]Stream #62968
Conversation
2d4155d
to
4326a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM AFAICS! Pending evolution approval.
Need to decide what swift version this lands in and if we can get it into release/5.8 - cc @beccadax or @DougGregor would know, but I guess it depends on quickness of the SE review
/// 1. The ``continuation`` which should be retained by the producer and is used | ||
/// to yield new elements to the stream and finish it. | ||
/// 2. The ``stream`` which is the actual ``AsyncStream`` and | ||
/// should be passed to the consumer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting seems off, 2 spaces
4326a34
to
1186392
Compare
1186392
to
e82417b
Compare
@swift-ci please smoke test |
e82417b
to
bc0053d
Compare
@swift-ci please smoke test |
@swift-ci build toolchain |
Seems the review is converging on using a tuple, might want to update this PR @FranzBusch :) |
bc0053d
to
a5fb888
Compare
@swift-ci please smoke test |
This is the implementation for swiftlang/swift-evolution#1824
a5fb888
to
26a089e
Compare
Since a commit was pushed after the last trigger: @swift-ci please smoke test |
ABI test failure, missing annotations on the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested how to fix the ABI checker issue inline; I believe that's the right combination but @tshortli could double check that.
Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
@swift-ci please smoke test |
1 similar comment
@swift-ci please smoke test |
This is the implementation for swiftlang/swift-evolution#1824