Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -package-name flag and De/serialize package name in module binary #62700

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Dec 19, 2022

De/serialize package name in module binary
Resoles rdar://103531218, rdar://103531208

De/serialize package name in module binary
Resoles rdar://103531218, rdar://103531208
@elsh
Copy link
Contributor Author

elsh commented Dec 19, 2022

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Dec 19, 2022

Fly-by reminder to increment SWIFTMODULE_VERSION_MINOR in this patch.

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serialization format version aside, this looks good to me!

@elsh
Copy link
Contributor Author

elsh commented Dec 20, 2022

@swift-ci test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@elsh elsh merged commit 7323d32 into main Dec 20, 2022
@elsh elsh deleted the es-pkg1 branch December 20, 2022 07:43
@@ -0,0 +1,15 @@
// RUN: %empty-directory(%t)
// RUN: %{python} %utils/split_file.py -o %t %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next time, there's a lit command to split a test into multiple source files now:

// RUN: split-file %s %t

//--- Lib.swift
//--- Client.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants