[stdlib] Recognize Unicode newlines in readLine() #21586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<rdar://problem/20013999> <https://bugs.swift.org/browse/SR-1280> <https://bugs.swift.org/browse/SR-6127>
benrimmington
force-pushed
the
readline-stripping-newline
branch
4 times, most recently
from
420b241
to
be88127
Compare
Remove intermediate byte array. Remove hard-coded newline sequences. Remove `_swift_stdlib_putchar_unlocked(_:)`.
benrimmington
force-pushed
the
readline-stripping-newline
branch
from
be88127
to
641ed37
Compare
|
I'll close this for now, since we're not sure if the existing behavior should change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/20013999
https://bugs.swift.org/browse/SR-1280
https://bugs.swift.org/browse/SR-6127