Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SE-2016: user-defined dynamically callable types. #948

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented Nov 3, 2018

  • Clarify the dynamic call resolution strategy:
    • Dynamic calls are resolved based on call-site syntax.
    • Use the withArguments: method if it's defined and there are no keyword arguments.
    • Otherwise, use the withKeywordArguments: method.
  • Update the implementation PR link.

- Clarify the dynamic call resolution strategy:
 - Dynamic calls are resolved based on call-site syntax.
 - Use the `withArguments:` method if it's defined and there are no keyword arguments.
 - Otherwise, use the `withKeywordArguments:` method.
- Update the implementation PR link.
@dan-zheng
Copy link
Contributor Author

@lattner: could you please review?

proposals/0216-dynamic-callable.md Outdated Show resolved Hide resolved
proposals/0216-dynamic-callable.md Outdated Show resolved Hide resolved
proposals/0216-dynamic-callable.md Show resolved Hide resolved
proposals/0216-dynamic-callable.md Outdated Show resolved Hide resolved
Address comments by @benrimmington.
Address comments by @benrimmington.
@lattner
Copy link
Collaborator

lattner commented Nov 7, 2018

LGTM, thank you!

@lattner lattner merged commit 6c734a0 into swiftlang:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants