Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcurrentRequestsHttpConnectionFilter should leverage NettyConnection.onClosing() instead of ConnectionContext.onClose() #309

Closed
jayv opened this issue Feb 14, 2019 · 1 comment

Comments

@jayv
Copy link
Contributor

jayv commented Feb 14, 2019

We used to set maxPipelinedRequests = 0 from NettyConnection.onClosing() which lead to misleading error messages. With the improved API on RequestConcurrencyController to indicate RejectedPermanently, we can minimize unnecessary failed requests on connection closure by triggering RejectedPermanently from NettyConnection.onClosing() however it’s not exposed.

AbstractStreamingHttpConnection has been modified to work around the shortcoming that ConcurrentRequestsHttpConnectionFilter has no access to onClosing(), once we make it available on NettyConnectionContext we must also update AbstractStreamingHttpConnection to leverage onClosing() again.

@idelpivnitskiy
Copy link
Member

ConcurrentRequestsHttpConnectionFilter was removed in #948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants