Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coremltools.utils.evaluate_regressor requires target parameter only with 'prediction' value #58

Closed
alkravchenko opened this issue Oct 31, 2017 · 1 comment · Fixed by #1572
Labels
bug Unexpected behaviour that should be corrected (type)

Comments

@alkravchenko
Copy link

coremltools.utils.evaluate_regressor accepts target parameter only with 'prediction' column name. If i try set any other name for column then i get error "KeyError: 'prediction'".

@TobyRoseman TobyRoseman added the bug Unexpected behaviour that should be corrected (type) label Oct 31, 2017
@srikris srikris added the python label Dec 9, 2019
@TobyRoseman
Copy link
Collaborator

Looking at the code, it seem the target parameter is only used for getting predictions from the MLModel. I agree it would make more sense for it also to be the column name in the data.

This would be a simple change to make. However it would also be an API breaking change.

This is also an issue with evaluate_classifier. However it's not an issue with evaluate_classifier_with_probabilities. So things seem a bit inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behaviour that should be corrected (type)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants