Stack name #206
Merged
Stack name #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subfuzion
reviewed
Sep 20, 2016
| @@ -144,20 +146,25 @@ func parse(t *testing.T, test *TestSpec) { | |||
|
|
|||
| func (a serviceMap) compare(b serviceMap) bool { | |||
| if a.Image != b.Image { | |||
| fmt.Printf("Images don't match: %v != %v\n", a.Image, b.Image) | |||
There was a problem hiding this comment.
It's better to use t.Log/t.Logf since these print to stderr and since the output is in order and where you expect to see it when it's printed as the test runs. You can add a t *testing.T arg to compare and pass it from the calling function.
bquenin
approved these changes
Sep 20, 2016
|
👍 |
subfuzion
added
area/stack
version/0.1
and removed
version/0.1
area/api
area/cli
area/docs
area/service
area/stack
kind/docs
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "amp stack ls"
update amp stack stop, rm to handle both id and name
fixe some issues
test: make test-stack