-
-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Es5 #147
Es5 #147
Conversation
DxCx
commented
Sep 14, 2016
•
edited
Loading
edited
- Update CHANGELOG.md with your change (include reference to issue & this PR)
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
json: true, | ||
resolveWithFullResponse: true, | ||
private getCSRFAndCookieThen(callback: (csrf: string, cookie: string) => any): Promise<any> { | ||
return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should just be return rp({ ... }).then(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not working,
RP is not returning native promises, but Bluebird one,
used this to convert Bluebird to native.
Also, this code will be eliminated soon if i got it right from @helfer
Do we need to add typings for es6-promise as well? |
Alright, let's ship it! |
Thanks for the quick turnaround! |
ofcourse :) |
Closes #146 |