Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs don't match typescript types #5870

Closed
dborstelmann opened this issue Nov 6, 2021 · 1 comment
Closed

Docs don't match typescript types #5870

dborstelmann opened this issue Nov 6, 2021 · 1 comment

Comments

@dborstelmann
Copy link

https://www.apollographql.com/docs/apollo-server/migration/#handler-is-always-async

This doc says callback can be ignored.

Expected 3 arguments, but got 2.ts(2554)
handler.d.ts(87, 5): An argument for 'callback' was not provided.
const apolloHandler: (event: any, context: Context, callback: Callback<any>) => void | Promise<any>

apollo-server-lambda 3.4

@glasser
Copy link
Member

glasser commented Nov 10, 2021

Duplicate of #5592. There's a discussion of a potential fix on #5593 but the submitted PR does not build.

@glasser glasser closed this as completed Nov 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants