Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing apollo-upload-server dependency #1220

Closed
olistic opened this issue Jun 22, 2018 · 1 comment
Closed

Missing apollo-upload-server dependency #1220

olistic opened this issue Jun 22, 2018 · 1 comment

Comments

@olistic
Copy link
Contributor

olistic commented Jun 22, 2018

Intended outcome:

apollo-server-lambda@rc can be used.

Actual outcome:

Failure due to missing apollo-upload-server dependency. Actual error is: "Cannot find module 'apollo-upload-server'". I see that apollo-upload-server is referenced by apollo-server-core here, but it's not included in the core's dependencies. Could that be the issue?

Adding apollo-upload-server to the dependencies of apollo-server-core should fix this issue. Let me know if you agree, and I'll be happy to submit a PR.

More info:

  • Node version: v8.10.
  • Using serverless framework.
  • graphql's lambda handler:
const { ApolloServer } = require('apollo-server-lambda');

const resolvers = require('./data/resolvers');
const typeDefs = require('./data/typeDefs');

const server = new ApolloServer({
  typeDefs,
  resolvers,
});

exports.handler = server.createHandler();
@evans
Copy link
Contributor

evans commented Jun 22, 2018

Thank you published in rc.2!

@evans evans closed this as completed Jun 22, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants