diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f97ef1eb97..95ca1a93620 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ The version headers in this history reflect the versions of Apollo Server itself ## vNEXT - `apollo-server-core`: Fix build error when building with `@rollup/plugin-commonjs`. [PR #5797](https://github.com/apollographql/apollo-server/pull/5797) +- `apollo-server-plugin-response-cache`: Add missing dependency on `apollo-server-types` (broken since v3.0.0). [Issue #5804](https://github.com/apollographql/apollo-server/issues/5804) [PR #5816](https://github.com/apollographql/apollo-server/pull/5816) + ## v3.4.0 - `apollo-server-core`: You can now specify your own `DocumentStore` (a `KeyValueStore`) for Apollo Server's cache of parsed and validated GraphQL operation abstract syntax trees via the new `documentStore` constructor option. **This replaces the `experimental_approximateDocumentStoreMiB` option.** You can replace `new ApolloServer({experimental_approximateDocumentStoreMiB: approximateDocumentStoreMiB, ...moreOptions})` with: diff --git a/packages/apollo-server-plugin-response-cache/package.json b/packages/apollo-server-plugin-response-cache/package.json index c00a3089eb3..c88cc211722 100644 --- a/packages/apollo-server-plugin-response-cache/package.json +++ b/packages/apollo-server-plugin-response-cache/package.json @@ -21,9 +21,7 @@ }, "dependencies": { "apollo-server-caching": "file:../apollo-server-caching", - "apollo-server-plugin-base": "file:../apollo-server-plugin-base" - }, - "devDependencies": { + "apollo-server-plugin-base": "file:../apollo-server-plugin-base", "apollo-server-types": "file:../apollo-server-types" }, "peerDependencies": { diff --git a/packages/apollo-server-plugin-response-cache/src/ApolloServerPluginResponseCache.ts b/packages/apollo-server-plugin-response-cache/src/ApolloServerPluginResponseCache.ts index b424b77053a..71da54b6fc4 100644 --- a/packages/apollo-server-plugin-response-cache/src/ApolloServerPluginResponseCache.ts +++ b/packages/apollo-server-plugin-response-cache/src/ApolloServerPluginResponseCache.ts @@ -5,9 +5,10 @@ import type { import type { GraphQLRequestContext, GraphQLResponse, + CacheHint, + ValueOrPromise, } from 'apollo-server-types'; import { KeyValueCache, PrefixingKeyValueCache } from 'apollo-server-caching'; -import type { CacheHint, ValueOrPromise } from 'apollo-server-types'; import { CacheScope } from 'apollo-server-types'; // XXX This should use createSHA from apollo-server-core in order to work on