diff --git a/package-lock.json b/package-lock.json index d7626102b93..dada7c3d869 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4057,6 +4057,7 @@ "apollo-graphql": "^0.3.4", "apollo-server-caching": "file:packages/apollo-server-caching", "apollo-server-env": "file:packages/apollo-server-env", + "apollo-server-errors": "file:packages/apollo-server-errors", "apollo-server-types": "file:packages/apollo-server-types", "async-retry": "^1.2.1", "graphql-extensions": "file:packages/graphql-extensions" diff --git a/packages/apollo-engine-reporting/package.json b/packages/apollo-engine-reporting/package.json index 219cdc39aee..38bc5c023f7 100644 --- a/packages/apollo-engine-reporting/package.json +++ b/packages/apollo-engine-reporting/package.json @@ -15,6 +15,7 @@ "apollo-graphql": "^0.3.4", "apollo-server-caching": "file:../apollo-server-caching", "apollo-server-env": "file:../apollo-server-env", + "apollo-server-errors": "file:../apollo-server-errors", "apollo-server-types": "file:../apollo-server-types", "async-retry": "^1.2.1", "graphql-extensions": "file:../graphql-extensions" diff --git a/packages/apollo-engine-reporting/src/treeBuilder.ts b/packages/apollo-engine-reporting/src/treeBuilder.ts index cd4b2341196..01e499d7834 100644 --- a/packages/apollo-engine-reporting/src/treeBuilder.ts +++ b/packages/apollo-engine-reporting/src/treeBuilder.ts @@ -5,6 +5,7 @@ import { responsePathAsArray, } from 'graphql'; import { Trace, google } from 'apollo-engine-reporting-protobuf'; +import { PersistedQueryNotFoundError } from 'apollo-server-errors'; function internalError(message: string) { return new Error(`[internal apollo-server error] ${message}`); @@ -77,6 +78,10 @@ export class EngineReportingTreeBuilder { public didEncounterErrors(errors: GraphQLError[]) { errors.forEach(err => { + if (err instanceof PersistedQueryNotFoundError) { + return; + } + // This is an error from a federated service. We will already be reporting // it in the nested Trace in the query plan. // diff --git a/packages/apollo-engine-reporting/tsconfig.json b/packages/apollo-engine-reporting/tsconfig.json index 7ee857f33a1..ca382f1094c 100644 --- a/packages/apollo-engine-reporting/tsconfig.json +++ b/packages/apollo-engine-reporting/tsconfig.json @@ -8,6 +8,7 @@ "exclude": ["**/__tests__", "**/__mocks__"], "references": [ { "path": "../graphql-extensions" }, + { "path": "../apollo-server-errors" }, { "path": "../apollo-server-types" }, ] }