From 4122a1b6cc1461ed6bb9eaf4f2cedf712d582669 Mon Sep 17 00:00:00 2001 From: Conrad VanLandingham Date: Wed, 5 Oct 2016 10:57:45 -0500 Subject: [PATCH 1/4] update connect example --- README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 78e57ccbc2c..fffa1d31bf6 100644 --- a/README.md +++ b/README.md @@ -46,15 +46,18 @@ app.listen(PORT); ### Connect ```js import connect from 'connect'; +import bodyParser from 'body-parser'; import { apolloConnect } from 'apollo-server'; +import http from 'http'; const PORT = 3000; var app = connect(); -app.use('/graphql', bodyParser.json(), apolloConnect({ schema: myGraphQLSchema })); +app.use('/graphql', bodyParser.json()); +app.use('/graphql', apolloConnect({ schema: myGraphQLSchema })); -app.listen(PORT); +http.createServer(app).listen(PORT); ``` ### Hapi From f16b714fc59d2ac5cd002459afa7c675b8136867 Mon Sep 17 00:00:00 2001 From: Conrad VanLandingham Date: Wed, 5 Oct 2016 10:58:45 -0500 Subject: [PATCH 2/4] Add connect readme change to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f6a2f74f71..2d09c7286b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### VNEXT * Pass `ctx` instead of `ctx.request` to options function in Koa integration ([@HriBB](https://github.com/HriBB)) in [PR #154](https://github.com/apollostack/apollo-server/pull/154) * Manage TypeScript declaration files using npm. ([@od1k](https:/github.com/od1k) in [#162](https://github.com/apollostack/apollo-server/pull/162)) +* Fix connect example in readme ### v0.3.2 * Added missing exports for hapi integration ([@nnance](https://github.com/nnance)) in [PR #152](https://github.com/apollostack/apollo-server/pull/152) From 9653ea4d800d1b6e9fc2e4f367da9e9b90a79357 Mon Sep 17 00:00:00 2001 From: Conrad VanLandingham Date: Wed, 5 Oct 2016 11:02:06 -0500 Subject: [PATCH 3/4] Add author/pr# --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d09c7286b9..a6ae8e14687 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ### VNEXT * Pass `ctx` instead of `ctx.request` to options function in Koa integration ([@HriBB](https://github.com/HriBB)) in [PR #154](https://github.com/apollostack/apollo-server/pull/154) * Manage TypeScript declaration files using npm. ([@od1k](https:/github.com/od1k) in [#162](https://github.com/apollostack/apollo-server/pull/162)) -* Fix connect example in readme +* Fix connect example in readme. ([@conrad-vanl](https://github.com/conrad-vanl) in [#17](https://github.com/apollostack/apollo-server/pull/17)) ### v0.3.2 * Added missing exports for hapi integration ([@nnance](https://github.com/nnance)) in [PR #152](https://github.com/apollostack/apollo-server/pull/152) From 9b9f4a7b0035eb5a32125aad2266d228420ecda2 Mon Sep 17 00:00:00 2001 From: Conrad VanLandingham Date: Wed, 5 Oct 2016 11:02:50 -0500 Subject: [PATCH 4/4] Do'oh! Fix issue number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a6ae8e14687..ef5ed85e246 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ### VNEXT * Pass `ctx` instead of `ctx.request` to options function in Koa integration ([@HriBB](https://github.com/HriBB)) in [PR #154](https://github.com/apollostack/apollo-server/pull/154) * Manage TypeScript declaration files using npm. ([@od1k](https:/github.com/od1k) in [#162](https://github.com/apollostack/apollo-server/pull/162)) -* Fix connect example in readme. ([@conrad-vanl](https://github.com/conrad-vanl) in [#17](https://github.com/apollostack/apollo-server/pull/17)) +* Fix connect example in readme. ([@conrad-vanl](https://github.com/conrad-vanl) in [#165](https://github.com/apollostack/apollo-server/pull/165)) ### v0.3.2 * Added missing exports for hapi integration ([@nnance](https://github.com/nnance)) in [PR #152](https://github.com/apollostack/apollo-server/pull/152)