Skip to content
This repository was archived by the owner on Apr 14, 2023. It is now read-only.

Incorrect peer dependency warning #78

Closed
burck1 opened this issue Sep 18, 2017 · 7 comments
Closed

Incorrect peer dependency warning #78

burck1 opened this issue Sep 18, 2017 · 7 comments
Assignees

Comments

@burck1
Copy link

burck1 commented Sep 18, 2017

Intended outcome:
Using the apollo-link-core npm package

Actual outcome:
Received a warning on install of the npm package

warning "graphql-tag@2.4.2" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0".

How to reproduce the issue:
Make sure you have yarn installed: https://yarnpkg.com/en/docs/install
(It looks like npm does not verify peer dependencies?)

> mkdir test
> cd test
> yarn init -y
> yarn add apollo-link-core
...
warning "graphql-tag@2.4.2" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0".
...
@jbaxleyiii
Copy link
Contributor

I'm going to move graphql to a peer dep which will fix this!

@burck1
Copy link
Author

burck1 commented Oct 11, 2017

Awesome!

@jbaxleyiii jbaxleyiii added this to the Apollo Client 2.0 Launch milestone Oct 12, 2017
@jbaxleyiii
Copy link
Contributor

done via #144

@ash0080
Copy link

ash0080 commented Jan 15, 2018

apollo-link-http@1.3.2 requires a peer of graphql@^0.11.0 but none is installed. You must install peer dependencies yourself.

"dependencies": {
    "apollo-cache-inmemory": "^1.1.5",
    "apollo-client": "^2.2.0",
    "apollo-link": "^1.0.7",
    "apollo-link-error": "^1.0.3",
    "apollo-link-http": "^1.3.2",
    "apollo-link-retry": "^2.1.1",
    "apollo-link-ws": "^1.0.4",
    "apollo-utilities": "^1.0.4",
    "co-wechat-api": "^3.3.4",
    "co-wechat-oauth": "^2.0.1",
    "connect-timeout": "^1.9.0",
    "cookie-parser": "^1.4.3",
    "cors": "^2.8.4",
    "express": "^4.16.2",
    "got": "^8.0.2",
    "graphql": "^0.12.3",
    "graphql-tag": "^2.6.1",
    "incache": "^7.0.0",
    "jsgql": "^1.0.2",
    "leancloud-storage": "^3.5.0",
    "leanengine": "^3.0.2",
    "lodash.sample": "^4.2.1",
    "ms": "^2.1.1",
    "node-fetch": "^1.7.3",
    "prepend-http": "^2.0.0",
    "subscriptions-transport-ws": "^0.9.5",
    "wechat": "^2.1.0",
    "ws": "^4.0.0"
  },

@Northshoot
Copy link

seems like bug resurfaced. Getting same error.

@danilomiranda
Copy link

Same here :(

@ShunnyBunny
Copy link

Same here. Do I need to add this dependency?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants