Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in README's "Important discussions" section #1922

Closed
tohjustin opened this issue Jul 19, 2017 · 6 comments
Closed

Broken link in README's "Important discussions" section #1922

tohjustin opened this issue Jul 19, 2017 · 6 comments

Comments

@tohjustin
Copy link

tohjustin commented Jul 19, 2017

Intended outcome:

Clicking on the link labelled as Long conversation about different client options, before this repo existed under the Important discussions section should bring the user to a valid webpage.

Actual outcome:

Clicking on the link brings the user to a Github 404 webpage (apollographql/apollo#1).

How to reproduce the issue:

  1. Go to https://github.com/apollographql/apollo-client
  2. Click on the link at the 4th link labelled as "Long conversation about different client options, before this repo existed" under the "Important discussions" section (located near the bottom of the page)
  3. Browser is directed to Client Side API apollo#1 with a Github 404 message

Version

  • apollo-client@1.9.0
@jbaxleyiii
Copy link
Contributor

@tohjustin would you be able to open a PR for this fix?

@tohjustin
Copy link
Author

@jbaxleyiii I would love to make a PR to fix this 😄

The only blocker I have right now is that I'm not too sure what link to use for the fix (I'm guessing the current link we have in the README broke when issue tracking in https://github.com/apollographql/apollo have been disabled)

@jbaxleyiii
Copy link
Contributor

haha oh! Sorry I misread! I'll get that for you!

@jbaxleyiii
Copy link
Contributor

ah, this was my fault. I closed issues on the Apollo project for clarity. A lot of people opened AC issues on that repo. Hmmm, I'll think through an option, maybe I'll move it here and close it so it an be linked

@stale
Copy link

stale bot commented Aug 10, 2017

This issue has been automatically marked as stale becuase it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Apollo Client!

@stale stale bot closed this as completed Aug 24, 2017
@stale
Copy link

stale bot commented Aug 24, 2017

This issue has been automatically closed because it has not had recent activity after being marked as stale. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to Apollo Client!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants