Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issue with Proguard Rules #23

Open
caleb654 opened this issue Nov 11, 2024 · 3 comments
Open

[Bug]: Issue with Proguard Rules #23

caleb654 opened this issue Nov 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@caleb654
Copy link

Version

1.3.0

Environment that reproduces the issue

Android

Is it reproducible in the example application?

Yes

Reproduction steps

In the example app you include proguard rules. Without them a release build fails. However these proguard rules cause my builds to run much slower and cause them to fail in my deployment pipeline (Codemagic). Is there any work around for this where I could remove those rules? Or some other solution?

Expected result

N/A

Actual result

N/A

Additional context

No response

Relevant logs output

ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/calebschantz/Desktop/test_app/build/app/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class com.google.android.play.core.splitcompat.SplitCompatApplication (referenced from: io.flutter.app.FlutterPlayStoreSplitApplication and 1 other context)
Missing class com.google.android.play.core.splitinstall.SplitInstallManager (referenced from: com.google.android.play.core.splitinstall.SplitInstallManager io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.splitInstallManager and 4 other contexts)
Missing class com.google.android.play.core.splitinstall.SplitInstallRequest$Builder (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.splitinstall.SplitInstallRequest (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.splitinstall.SplitInstallStateUpdatedListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.destroy() and 1 other context)
Missing class com.google.android.play.core.tasks.OnFailureListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.tasks.OnSuccessListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.tasks.Task (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String) and 1 other context)
@caleb654 caleb654 added the bug Something isn't working label Nov 11, 2024
@ThibaultBee
Copy link
Member

Hi,

I included this rules because I fell on the same issue. It is referenced on stackoverflow (for example: https://stackoverflow.com/questions/76800185/how-to-keep-some-com-google-android-play-core-classes-reported-missing-by-r8-d). I am not sure it is related to the api.video uploader package.
Yes, R8 takes a long time.

The only workaround I see are:

  • build in debug
  • increase the pipeline timeout

@ThibaultBee
Copy link
Member

On last workaround:

@caleb654
Copy link
Author

I'm pretty sure it is caused by the package. I tested in an example project with all my dependencies and as soon as I add video_uploader I get the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants