Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of code shared by acq_irrad_interactive() and acq_fraction_interactive() #4

Open
aphalo opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aphalo
Copy link
Owner

aphalo commented Apr 18, 2023

The remaining functions need to be updated to include the features added recently to acq_irrad_interactive() if these features are useful.

@aphalo aphalo self-assigned this Apr 18, 2023
@aphalo aphalo added the enhancement New feature or request label Apr 18, 2023
@aphalo aphalo added this to the v0.3.3 milestone Apr 18, 2023
@aphalo aphalo modified the milestones: v0.3.3, v0.3.4 May 9, 2023
@aphalo aphalo modified the milestones: v0.3.4, Future version May 31, 2023
@aphalo
Copy link
Owner Author

aphalo commented Dec 21, 2023

When implementing the new features in additional functions, we need to see how much code from acq_irrad_interactive() can be refactored into separate functions, both to make the code base smaller, but also to make easier coordinated updates of irradiance and fraction related functions.

@aphalo aphalo modified the milestones: V 0.5.0, 0.4.5 Jan 19, 2024
@aphalo aphalo changed the title Development of acq_irrad_interactive() is ahead of the other functions Refactoring of code shared by acq_irrad_interactive() and acq_farction_interactive() Aug 2, 2024
@aphalo
Copy link
Owner Author

aphalo commented Aug 2, 2024

  • Update acq_fraction_interactive() to incorporate all improvements made to acq_irrad_interactive().
  • Refactor as much shared code as possible before their code diverges once again!

The functionality of the "irrad" and "fluence" acquisition functions is now all in acq_irrad_interactive() and the development of acq_fraction_interactive() has catched up and these two functions share a lot of code. As each function contains a lot of code, moving the shared code to separate utility functions seems like the best option. However, some of these functions would require many formal parameters, suggesting that it is best to start by collecting related sets of parameters into lists that can be more easily passed between functions and stored together as presets.

@aphalo aphalo changed the title Refactoring of code shared by acq_irrad_interactive() and acq_farction_interactive() Refactoring of code shared by acq_irrad_interactive() and acq_fraction_interactive() Dec 26, 2024
@aphalo aphalo modified the milestones: 0.4.5, v0.5.3 Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant