Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge miscalculation regarding y-axis tickAmount #191

Closed
jimfilippou opened this issue Nov 8, 2018 · 6 comments
Closed

Microsoft Edge miscalculation regarding y-axis tickAmount #191

jimfilippou opened this issue Nov 8, 2018 · 6 comments

Comments

@jimfilippou
Copy link
Contributor

Codepen

https://codepen.io/jimfilippou-the-animator/pen/vQGNqz?editors=0010

Browser

  • Microsoft Edge

Explanation

  • What is the behavior you expect?
    expectation

  • What is happening instead?
    reality

  • What error message are you getting?
    No error message

@jimfilippou
Copy link
Contributor Author

console.log(window.navigator.userAgent);
// "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134"

If that helps

@junedchhipa
Copy link
Contributor

There is 1 condition for IE, which should not be returning true for Edge.
I will change the function to target only IE11.

@junedchhipa
Copy link
Contributor

This commit 6e23336 fixes it

@jimfilippou
Copy link
Contributor Author

I also believe this fixes the problem, when is the next build 😄 ?

@junedchhipa
Copy link
Contributor

This weekend.

@junedchhipa
Copy link
Contributor

Fixed in 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants