Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the states.active.filter.type to 'none' does not work #180

Closed
johuhype opened this issue Oct 29, 2018 · 6 comments
Closed

Setting the states.active.filter.type to 'none' does not work #180

johuhype opened this issue Oct 29, 2018 · 6 comments

Comments

@johuhype
Copy link

Type 'none' for the active state does not work:

                    states: {
                        active: {
                             filter: { type: 'none', value: 1 }
                        }
                    }

Instead of nothing happening, the selected item will get highlighted.

However, it is possible to use type-darken and value 1 as long as its not working. This will get the desired none effect:
states: {
active: {
filter: { type: 'darken', value: 1 }
}
}

@junedchhipa
Copy link
Contributor

I cannot reproduce this issue.
Setting filter.type: none works as expected.

Can you create a codepen, please?

@johuhype
Copy link
Author

https://codepen.io/anon/pen/RemGxm

You need to enable the responsive mode in chrome. Then try to click the blue circle with the round mouse cursor. The hover effect will become active.

I can fix this by changing type none to darken or if I also put

                             hover: {
                                 filter: { type: 'none' }
                             }

there. But the hover effect should probably not be activated by clicking.

@junedchhipa
Copy link
Contributor

junedchhipa commented Oct 30, 2018

The hover effect is not activated by the click, but it is activated when you move the mouse over the path.

So, if you don't want any states, then turning off both active and hover is the correct configuration.

states: {
  hover: {
    filter: { type: 'none' }
  },
  active: {
    filter: { type: 'none' }
  },
}

@johuhype
Copy link
Author

No, in responsive mode, there is no hover (as of touch mode with smart devices).

I agree that hover will be activated when you are in desktop mode and just move the mouse over the path.
When you are in touch mode, it is not activated which is correct as there is no "mouse over".
However it will get activated there when you click it in the right spot of the blue circle color. Which is not correct I think.

@junedchhipa
Copy link
Contributor

junedchhipa commented Oct 30, 2018

@johuhype I misunderstood your previous comment. It's clear now.
I will make the corrections. Thank you.

@junedchhipa
Copy link
Contributor

Fixed in 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants