Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support for cuda 11 #6157

Closed
yzh119 opened this issue Jul 28, 2020 · 2 comments
Closed

[feature request] Support for cuda 11 #6157

yzh119 opened this issue Jul 28, 2020 · 2 comments

Comments

@yzh119
Copy link
Member

yzh119 commented Jul 28, 2020

Currently, if I build tvm with cublas and CUDA 11, I'll encounter the following error:

/home/***/repo/incubator-tvm/src/runtime/contrib/cublas/cublas.cc: In function ‘void tvm::contrib::CallLtIgemm(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*, cublasLtHandle_t)’:
/home/***/repo/incubator-tvm/src/runtime/contrib/cublas/cublas.cc:175:63: error: cannot convert ‘cudaDataType_t’ to ‘cublasComputeType_t’
  175 |   CHECK_CUBLAS_ERROR(cublasLtMatmulDescCreate(&operationDesc, CUDA_R_32I));
      |                                                               ^~~~~~~~~~
      |                                                               |
      |                                                               cudaDataType_t

which is no longer compatible with CUDA 11 cublasLtMatmulDescCreate interface, the new API has three arguments:

cublasStatus_t cublasLtMatmulDescCreate(
	cublasLtMatmulDesc_t *matmulDesc, 
	cudaDataType computeType);

it breaks the old api which only has two arguments.

I'm not sure if there are other breaking changes in CUDA 11 that would fail the compilation of tvm. I think a macro like #if CUDART_VERSION >= 11000 could solve the problem mentioned above.

@tqchen
Copy link
Member

tqchen commented Jul 28, 2020

Thanks @yzh119 for bringing it up, would you like to take a stab? cc @Laurawly @icemelon9

@tqchen
Copy link
Member

tqchen commented Aug 5, 2020

closed by #6213 thanks to @lanchongyizu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants