Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing ops should support unsigned integer types #10064

Closed
8 tasks done
AndrewZhaoLuo opened this issue Jan 25, 2022 · 2 comments
Closed
8 tasks done

Indexing ops should support unsigned integer types #10064

AndrewZhaoLuo opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
beginner-friendly type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs

Comments

@AndrewZhaoLuo
Copy link
Contributor

AndrewZhaoLuo commented Jan 25, 2022

Right now stuff like gather, take, gather_nd, scatter are bound to signed integers. This should be pretty simple to add, we just need to change the type relations to support, most of the topi should work out of box.

Portions of #10053 apply insight into how to do this.

List of ops:

@yuanfz98
Copy link
Contributor

Hello @AndrewZhaoLuo,

Can I take the last 5 ops (scatter, scatter_add, scatter_nd, unravel_index, adv_index)?

@AndrewZhaoLuo
Copy link
Contributor Author

Yeah sure, thanks for the help B)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs
Projects
None yet
Development

No branches or pull requests

2 participants