Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t3c to invalidate cache if req keys change #6327

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Nov 3, 2021

Fixes t3c to invalidate cached objects if the request keys change, for example if a Server's CDN changes.

Without this, IMS requests are being issued, but for example, t3c gets the Server, and then gets the Server's Profile, and doesn't correctly invalidate a cached Profile if the Server's Profile changed (but the old Profile didn't). This resulted in old data being incorrectly used, and config generating incorrectly, which could be subtle (a Profile with a single records.config Parameter) or catastrophic (a server switched to a different CDN).

Includes tests.
Includes changelog.
No docs, no interface change.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (T3C, formerly ORT)

What is the best way to verify this PR?

Run tests. Run t3c so it stores a cache, change the server's CDN in Traffic Ops and run t3c again, verify remap.config domains are the new CDN.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 6.0.0

PR submission checklist

@rob05c rob05c added bug something isn't working as intended cache-config Cache config generation labels Nov 3, 2021
@rob05c rob05c force-pushed the fix-t3c-cache-key-changes branch from a70eb9b to ca36d93 Compare November 3, 2021 21:18
@zrhoffman
Copy link
Member

zrhoffman commented Nov 4, 2021

In order for CI to pass, #6327 needs to be rebased onto the apache:master branch now that the CI fix in #6329 is merged:

git remote add apache git@github.com:apache/trafficcontrol.git
git fetch apache
git rebase apache
git push your-fork your-branch --force

@rob05c rob05c force-pushed the fix-t3c-cache-key-changes branch from ca36d93 to f29cc42 Compare November 4, 2021 18:33
@rob05c rob05c force-pushed the fix-t3c-cache-key-changes branch from f29cc42 to 0dd8e89 Compare November 19, 2021 16:36
@rob05c rob05c force-pushed the fix-t3c-cache-key-changes branch from 0dd8e89 to 5a82fd8 Compare November 19, 2021 16:40
@rawlinp rawlinp merged commit 0bfe30b into apache:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended cache-config Cache config generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants