Fix t3c to invalidate cache if req keys change #6327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes t3c to invalidate cached objects if the request keys change, for example if a Server's CDN changes.
Without this, IMS requests are being issued, but for example, t3c gets the Server, and then gets the Server's Profile, and doesn't correctly invalidate a cached Profile if the Server's Profile changed (but the old Profile didn't). This resulted in old data being incorrectly used, and config generating incorrectly, which could be subtle (a Profile with a single records.config Parameter) or catastrophic (a server switched to a different CDN).
Includes tests.
Includes changelog.
No docs, no interface change.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run tests. Run t3c so it stores a cache, change the server's CDN in Traffic Ops and run t3c again, verify remap.config domains are the new CDN.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist