Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes the Profile feature #26462

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jan 11, 2024

SUMMARY

As part of the 4.0 approved initiatives, this PR removes the Profile feature given that it's not actively maintained and not widely used.

The following module, accessible from the Profile menu option, will be removed:

Screenshot 2024-01-11 at 16 18 39

TESTING INSTRUCTIONS

CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Jan 11, 2024
@michael-s-molina michael-s-molina requested review from villebro and a team and removed request for villebro January 11, 2024 19:20
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03b8d8f) 59.15% compared to head (07c1a80) 59.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26462      +/-   ##
==========================================
+ Coverage   59.15%   59.32%   +0.17%     
==========================================
  Files        1930     1910      -20     
  Lines       75243    74890     -353     
  Branches     8429     8398      -31     
==========================================
- Hits        44507    44428      -79     
+ Misses      28589    28319     -270     
+ Partials     2147     2143       -4     
Flag Coverage Δ
javascript 56.79% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina removed the hold! On hold label Jan 16, 2024
@michael-s-molina michael-s-molina merged commit 8f8c435 into apache:master Jan 18, 2024
33 checks passed
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants