-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the deprecated DASHBOARD_NATIVE_FILTERS feature flag #26329
refactor: Removes the deprecated DASHBOARD_NATIVE_FILTERS feature flag #26329
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26329 +/- ##
==========================================
+ Coverage 69.48% 69.49% +0.01%
==========================================
Files 1892 1892
Lines 74107 74092 -15
Branches 8254 8243 -11
==========================================
- Hits 51490 51487 -3
+ Misses 20541 20536 -5
+ Partials 2076 2069 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/pagination.tsx
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
Outdated
Show resolved
Hide resolved
710e1a0
to
2a50d2f
Compare
2a50d2f
to
7a2d4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
DASHBOARD_NATIVE_FILTERS
feature flag and enables the feature permanently.The previous value of the feature flag was
True
and now the feature is permanently enabled.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATION