Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes the deprecated DASHBOARD_NATIVE_FILTERS feature flag #26329

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 21, 2023

SUMMARY

As part of the 4.0 approved initiatives, this PR removes the DASHBOARD_NATIVE_FILTERS feature flag and enables the feature permanently.

The previous value of the feature flag was True and now the feature is permanently enabled.

TESTING INSTRUCTIONS

CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f63e66b) 69.48% compared to head (7a2d4f5) 69.49%.

Files Patch % Lines
...components/DashboardBuilder/DashboardContainer.tsx 0.00% 0 Missing and 1 partial ⚠️
...src/dashboard/components/DashboardBuilder/state.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26329      +/-   ##
==========================================
+ Coverage   69.48%   69.49%   +0.01%     
==========================================
  Files        1892     1892              
  Lines       74107    74092      -15     
  Branches     8254     8243      -11     
==========================================
- Hits        51490    51487       -3     
+ Misses      20541    20536       -5     
+ Partials     2076     2069       -7     
Flag Coverage Δ
hive 53.88% <ø> (ø)
javascript 56.86% <85.71%> (+0.01%) ⬆️
mysql 78.05% <ø> (ø)
postgres 78.15% <ø> (ø)
presto 53.83% <ø> (ø)
python 83.04% <ø> (ø)
sqlite 77.73% <ø> (ø)
unit 56.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina changed the title refactor: Removes the DASHBOARD_NATIVE_FILTERS feature flag refactor: Removes the deprecated DASHBOARD_NATIVE_FILTERS feature flag Dec 26, 2023
@michael-s-molina michael-s-molina requested a review from a team December 28, 2023 19:28
@michael-s-molina michael-s-molina marked this pull request as ready for review January 5, 2024 18:54
UPDATING.md Outdated Show resolved Hide resolved
superset-frontend/src/dashboard/actions/sliceEntities.ts Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/SaveModal.tsx Outdated Show resolved Hide resolved
superset-frontend/src/explore/components/SaveModal.tsx Outdated Show resolved Hide resolved
superset-frontend/src/pages/ChartCreation/index.tsx Outdated Show resolved Hide resolved
@michael-s-molina michael-s-molina force-pushed the remove-native-filters-ff branch from 2a50d2f to 7a2d4f5 Compare January 19, 2024 18:50
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 69b5701 into apache:master Jan 19, 2024
33 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/L v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants