Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixed time-series; time-series bar chart v2] Bar chart jumps to very narrow bars in larger time ranges #18232

Closed
3 tasks done
rumbin opened this issue Jan 31, 2022 · 4 comments
Labels
#bug Bug report validation:required A committer should validate the issue

Comments

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2022

Depending on the displayed time range, the width of the bar-chart bars becomes very narrow, up to the point where the bars become nearly invisible.

The effect depends on the selected time grain, but I haven't found a pattern yet.

I can replicate this on both, mixed time-series and time-series bar chart v2.

How to reproduce the bug

  1. Create a diagram of type mixed time-series (bar chart here!) or ** time-series bar chart v2**, based on a dataset that has at least 1 year of data in it
  2. Select a time range of 1 year
  3. Vary the time grain between weeks and quaters
  4. Activate Data Zoom and play with it; alternatively reduce the time range gradually

Expected results

The bars of the bar chart should continuously be varied according to the time grain and the time rage, so the bar-to-gap ratio is harmonic.

The old time-series bar chart may serve as a good example here.

Actual results

The width of the bars is harmonically scaled in some time ranges, but when a certain threshold is exceeded, the bar width jumps to nearly invisible vertical lines.

The odd thing here is, that I cannot identify a pattern here:

  • For weekly time-grain the jump is at about end of march, when the whole year is displayed.
  • For monthly time-grain the threshold is at the beginning of march. So far so good.
  • But: for quaterly time_grain the bars are always narrow lines, although there is by far enough space now.

Screenshots

The first gif shows that the threshold where the bars jump from narrow to wide and back can be narrowed by both Data Zoom and by changing the time range:

bar_chart_width_jump_weekly

The second gif shows that the threshold depends on the time grain, where the few quaterly bars behave most erratic:

bar_chart_width_jump_time_grain

Environment

  • browser type and version: Chrome 96.0.4664.93
  • superset version: 1.4.0
  • all other versions: as defined in Superset's Docker image
  • Feature flags:
# stable:
      "THUMBNAILS": True,
      "SQLLAB_BACKEND_PERSISTENCE": True,
      "ENABLE_TEMPLATE_PROCESSING": True,
      "DASHBOARD_CROSS_FILTERS": True,

      # experimental:
      "ALERT_REPORTS": True,
      "ALERTS_ATTACH_REPORTS": True,
      "DASHBOARD_NATIVE_FILTERS": True,

      # unclassified:
      "ENABLE_EXPLORE_DRAG_AND_DROP": True,
      "ENABLE_DND_WITH_CLICK_UX": True,

      # development:
      "DASHBOARD_NATIVE_FILTERS_SET": True

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@rumbin rumbin added the #bug Bug report label Jan 31, 2022
@geido geido added the validation:required A committer should validate the issue label Feb 1, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rumbin
Copy link
Contributor Author

rumbin commented Apr 17, 2022

This issue should not be closed by the stale bot, in my eyes.

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

@rumbin I don't want to dismissively close this, but it's been upward of a year, and I believe this was solved by a few correlated PRs. Can you verify this is resolved (or not!) in 2.0.1?

@rumbin
Copy link
Contributor Author

rumbin commented Jan 20, 2023

I cannot reproduce this issue any longer on v2.0.1 with Bar Chart v2 and custom x-axis enabled.
Closing it, @rusackas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report validation:required A committer should validate the issue
Projects
None yet
Development

No branches or pull requests

3 participants