Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter] Instant filter component will generate 2x more fetch #14706

Closed
3 tasks done
graceguo-supercat opened this issue May 19, 2021 · 2 comments · Fixed by #14770
Closed
3 tasks done

[native filter] Instant filter component will generate 2x more fetch #14706

graceguo-supercat opened this issue May 19, 2021 · 2 comments · Fixed by #14770
Assignees
Labels
#bug:performance Performance bugs #bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

How to reproduce the bug

  1. Go to dashboard
  2. add native filter component and add a value
  3. Check Apply changes instantly
  4. reload dashboard. You will see every charts are loaded 3 times. This issue cause dashboard load really slow.

Screenshots

G7lm7HcLC7

Environment

(please complete the following information):

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

cc @junlincc @villebro This issue is reported by open source user.

@graceguo-supercat graceguo-supercat added the #bug Bug report label May 19, 2021
@zhaoyongjie zhaoyongjie added the dashboard:native-filters Related to the native filters of the Dashboard label May 19, 2021
@zhaoyongjie
Copy link
Member

I have reproduced this bug, it depends on the default value whether populated.

@junlincc junlincc added the #bug:performance Performance bugs label May 19, 2021
@junlincc
Copy link
Member

junlincc commented May 19, 2021

Thanks for reporting and debugging @zhaoyongjie ! is expected behavior triggering query once or twice(with default value set up)?

@michael-s-molina though Apply changes instantly has been problematic, we may not remove it YET, since cascading filter ing built upon this logic.
Alternative is that to remove the Apply changes instantly checkbox, make cascading filter parent filter apply instantly(without any setting).

@simcha90 is probably the best person to solve this issue. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:performance Performance bugs #bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants