Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] When adding two native filters (first ok,second one partially filled) I lost the first one #12459

Closed
adam-stasiak opened this issue Jan 12, 2021 · 1 comment · Fixed by #12554
Labels
#bug:newfeature Bugs related to newly introduced features dashboard:native-filters Related to the native filters of the Dashboard

Comments

@adam-stasiak
Copy link
Contributor

When I add two new filters and:

  • first is correctly filled
  • second is partially filled
    And I click on Save on first filter -> I do not get information that this SAVE will not keep my filter when I quit this modal.

Expected results

We should indicate that progress will be lost and:

  • force user to finish or remove remaining filters before exit
  • discard not valid filter entries
  • keep them as draft not applicable for usage

@junlincc I think we should consider options for this.

Actual results

I do not get information that this SAVE will not keep my filter when I quit this modal.

Screenshots

Nagranie.z.ekranu.2020-12-22.o.00.01.28.mov

How to reproduce the bug

Enable Native filters
Go to filter adding on dashboard
I add two new filters and:

  • first is correctly filled
  • second is partially filled
    click on Save on first filter

Environment

docker
sha 90915db

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [ x] I have reproduced the issue with at least the latest released version of superset.
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

@adam-stasiak adam-stasiak added the #bug Bug report label Jan 12, 2021
@adam-stasiak adam-stasiak changed the title [dashboard][native-filter] When adding two filter (first ok,second one partially filled) I lost the first one [dashboard] When adding two native filters (first ok,second one partially filled) I lost the first one Jan 12, 2021
@junlincc junlincc added #bug:newfeature Bugs related to newly introduced features dashboard:native-filters Related to the native filters of the Dashboard and removed #bug Bug report Polidea labels Jan 12, 2021
@agatapst
Copy link
Contributor

agatapst commented Jan 13, 2021

Yeah, some info should be displayed here that first filter is not saved. I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:newfeature Bugs related to newly introduced features dashboard:native-filters Related to the native filters of the Dashboard
Projects
None yet
3 participants