From e80adab2009e0c62e3f6507546ed106cd47ebb49 Mon Sep 17 00:00:00 2001 From: lyndsiWilliams Date: Tue, 31 Jan 2023 16:16:18 -0600 Subject: [PATCH] Fix CREATE_DATASET_TEXT and tooltip in footer, add todo note to history functionality in DatabaseModal --- .../src/views/CRUD/data/database/DatabaseModal/index.tsx | 2 ++ .../src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx | 2 +- superset-frontend/src/views/CRUD/data/dataset/styles.ts | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index f7260952f8cb3..72d3ddfd90a27 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -656,6 +656,8 @@ const DatabaseModal: FunctionComponent = ({ }; const redirectURL = (url: string) => { + /* TODO (lyndsiWilliams): This check and passing history + as a prop can be removed once SQL Lab is in the SPA */ if (!isEmpty(history)) { history?.push(url); } else { diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx index 7f6717857f569..e0853cdc9d587 100644 --- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx +++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx @@ -106,7 +106,7 @@ function Footer({ } }; - const CREATE_DATASET_TEXT = t('Create Dataset and Create Chart'); + const CREATE_DATASET_TEXT = t('Create dataset and create chart'); const disabledCheck = !datasetObject?.table_name || !hasColumns || diff --git a/superset-frontend/src/views/CRUD/data/dataset/styles.ts b/superset-frontend/src/views/CRUD/data/dataset/styles.ts index 45082dea7d265..268b9e273e486 100644 --- a/superset-frontend/src/views/CRUD/data/dataset/styles.ts +++ b/superset-frontend/src/views/CRUD/data/dataset/styles.ts @@ -62,6 +62,7 @@ export const PanelRow = styled(Row)` export const FooterRow = styled(Row)` flex: 0 0 auto; height: ${({ theme }) => theme.gridUnit * 16}px; + z-index: 0; `; export const StyledLayoutHeader = styled.div`