From da46ad4013695c42d7a279ce677f67fdd05c3efe Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 31 Jul 2024 13:14:26 -0600 Subject: [PATCH] feat: adding AntdThemeProvider to storybook config (#29795) --- superset-frontend/.storybook/preview.jsx | 5 ++-- .../src/components/Badge/Badge.stories.tsx | 25 +++++++------------ .../src/components/Card/Card.stories.tsx | 7 +----- .../ProgressBar/ProgressBar.stories.tsx | 13 +++------- .../src/components/Tags/Tag.stories.tsx | 7 +----- .../src/components/Tags/TagsList.stories.tsx | 5 +--- 6 files changed, 18 insertions(+), 44 deletions(-) diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx index 42784d2d18381..ef27f3591e806 100644 --- a/superset-frontend/.storybook/preview.jsx +++ b/superset-frontend/.storybook/preview.jsx @@ -18,6 +18,7 @@ */ import { withJsx } from '@mihkeleidast/storybook-addon-source'; import { supersetTheme, ThemeProvider } from '@superset-ui/core'; +import { AntdThemeProvider } from '../src/components/AntdThemeProvider'; import { combineReducers, createStore, applyMiddleware, compose } from 'redux'; import thunk from 'redux-thunk'; import { Provider } from 'react-redux'; @@ -35,10 +36,10 @@ const store = createStore( const themeDecorator = Story => ( - <> + - + ); diff --git a/superset-frontend/src/components/Badge/Badge.stories.tsx b/superset-frontend/src/components/Badge/Badge.stories.tsx index 781f6220c723a..505c51ab38451 100644 --- a/superset-frontend/src/components/Badge/Badge.stories.tsx +++ b/superset-frontend/src/components/Badge/Badge.stories.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -import { AntdThemeProvider } from 'src/components/AntdThemeProvider'; import Badge, { BadgeProps } from '.'; export default { @@ -59,11 +58,7 @@ const SIZES = { defaultValue: undefined, }; -export const InteractiveBadge = (args: BadgeProps) => ( - - - -); +export const InteractiveBadge = (args: BadgeProps) => ; InteractiveBadge.args = { count: undefined, @@ -120,16 +115,14 @@ export const BadgeGallery = () => ( {SIZES.options.map(size => (

{size}

- - {COLORS.options.map(color => ( - - ))} - + {COLORS.options.map(color => ( + + ))}
))} diff --git a/superset-frontend/src/components/Card/Card.stories.tsx b/superset-frontend/src/components/Card/Card.stories.tsx index 83ad2369ed16d..dad913826284c 100644 --- a/superset-frontend/src/components/Card/Card.stories.tsx +++ b/superset-frontend/src/components/Card/Card.stories.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -import { AntdThemeProvider } from 'src/components/AntdThemeProvider'; import Card, { CardProps } from '.'; export default { @@ -24,11 +23,7 @@ export default { component: Card, }; -export const InteractiveCard = (args: CardProps) => ( - - - -); +export const InteractiveCard = (args: CardProps) => ; InteractiveCard.args = { padded: true, diff --git a/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx b/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx index 62ad8ae203e52..37f65357546c4 100644 --- a/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx +++ b/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -import { AntdThemeProvider } from 'src/components/AntdThemeProvider'; import ProgressBar, { ProgressBarProps } from '.'; export default { @@ -25,21 +24,15 @@ export default { }; export const InteractiveProgressBar = (args: ProgressBarProps) => ( - - - + ); export const InteractiveProgressCircle = (args: ProgressBarProps) => ( - - - + ); export const InteractiveProgressDashboard = (args: ProgressBarProps) => ( - - - + ); const commonArgs = { diff --git a/superset-frontend/src/components/Tags/Tag.stories.tsx b/superset-frontend/src/components/Tags/Tag.stories.tsx index bcd29cd131e50..b6d82bff93009 100644 --- a/superset-frontend/src/components/Tags/Tag.stories.tsx +++ b/superset-frontend/src/components/Tags/Tag.stories.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -import { AntdThemeProvider } from 'src/components/AntdThemeProvider'; import TagType from 'src/types/TagType'; import { Tag } from '.'; @@ -24,11 +23,7 @@ export default { title: 'Tags', component: Tag, }; -export const InteractiveTag = (args: TagType) => ( - - - -); +export const InteractiveTag = (args: TagType) => ; InteractiveTag.args = { editable: false, diff --git a/superset-frontend/src/components/Tags/TagsList.stories.tsx b/superset-frontend/src/components/Tags/TagsList.stories.tsx index 3c9a19ef3847e..622ab155e7486 100644 --- a/superset-frontend/src/components/Tags/TagsList.stories.tsx +++ b/superset-frontend/src/components/Tags/TagsList.stories.tsx @@ -17,7 +17,6 @@ * under the License. */ import TagType from 'src/types/TagType'; -import { AntdThemeProvider } from 'src/components/AntdThemeProvider'; import { TagsList } from '.'; import { TagsListProps } from './TagsList'; @@ -31,9 +30,7 @@ export const InteractiveTagsList = ({ editable, maxTags, }: TagsListProps) => ( - - - + ); const tags: TagType[] = [