From 8694429ea0f0e56827e7d9763ed8eff25adcc310 Mon Sep 17 00:00:00 2001
From: briannguyen4 <brian4nguyen@gmail.com>
Date: Wed, 26 Jan 2022 14:16:21 -0500
Subject: [PATCH] refactor: convert class component to functional component

---
 .../components/QueryAutoRefresh/index.jsx     | 38 +++++++++----------
 1 file changed, 17 insertions(+), 21 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx b/superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx
index 267b80a303512..d658bf6b45671 100644
--- a/superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx
+++ b/superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.jsx
@@ -16,8 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-
-import React from 'react';
+import React, { useState, useEffect } from 'react';
 import PropTypes from 'prop-types';
 import { bindActionCreators } from 'redux';
 import { connect } from 'react-redux';
@@ -29,8 +28,9 @@ const QUERY_UPDATE_BUFFER_MS = 5000;
 const MAX_QUERY_AGE_TO_POLL = 21600000;
 const QUERY_TIMEOUT_LIMIT = 10000;
 
-const QueryAutoRefresh = ({ offline, queries, queriesLastUpdate, actions }) => {
+function QueryAutoRefresh({ offline, queries, queriesLastUpdate, actions }) {
   const [offlineState, setOfflineState] = useState(offline);
+  let timer = null;
 
   const shouldCheckForQueries = () => {
     // if there are started or running queries, this method should return true
@@ -43,17 +43,6 @@ const QueryAutoRefresh = ({ offline, queries, queriesLastUpdate, actions }) => {
     );
   };
 
-  const startTimer = () => {
-    if (!timer) {
-      timer = setInterval(stopwatch(), QUERY_UPDATE_FREQ);
-    }
-  };
-
-  const stopTimer = () => {
-    clearInterval(timer);
-    timer = null;
-  };
-
   const stopwatch = () => {
     // only poll /superset/queries/ if there are started or running queries
     if (shouldCheckForQueries()) {
@@ -78,23 +67,30 @@ const QueryAutoRefresh = ({ offline, queries, queriesLastUpdate, actions }) => {
     }
   };
 
-  useEffect(() => {
-    console.log('component mounted!');
-    startTimer();
-  }, []);
+  const startTimer = () => {
+    if (!timer) {
+      timer = setInterval(stopwatch(), QUERY_UPDATE_FREQ);
+    }
+  };
+
+  const stopTimer = () => {
+    clearInterval(timer);
+    timer = null;
+  };
 
   useEffect(() => {
+    startTimer();
     return () => {
       stopTimer();
     };
   }, []);
 
   useEffect(() => {
-    actions.setUserOffline(offline);
-  }, [offline]);
+    actions.setUserOffline(offlineState);
+  }, [offlineState]);
 
   return null;
-};
+}
 
 QueryAutoRefresh.propTypes = {
   offline: PropTypes.bool.isRequired,