From 4c98433f54187377baae3f7ba20e622cff449e6a Mon Sep 17 00:00:00 2001 From: EugeneTorap Date: Fri, 27 Jan 2023 13:21:07 +0300 Subject: [PATCH] Remove excel logic from legacy API --- superset/views/core.py | 7 ------- superset/viz.py | 10 +--------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/superset/views/core.py b/superset/views/core.py index 984fe3815dcb5..d65023d600ba0 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -152,7 +152,6 @@ json_errors_response, json_success, validate_sqlatable, - XlsxResponse, ) from superset.views.log.dao import LogDAO from superset.views.sql_lab.schemas import SqlJsonPayloadSchema @@ -488,12 +487,6 @@ def generate_json( viz_obj.get_csv(), headers=generate_download_headers("csv") ) - if response_type == ChartDataResultFormat.XLSX: - return XlsxResponse( - viz_obj.get_excel(ChartDataResultFormat(response_type)), - headers=generate_download_headers("xlsx"), - ) - if response_type == ChartDataResultType.QUERY: return self.get_query_string_response(viz_obj) diff --git a/superset/viz.py b/superset/viz.py index bd2fbffecaa28..c4582925da120 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -56,7 +56,6 @@ from pandas.tseries.frequencies import to_offset from superset import app -from superset.common.chart_data import ChartDataResultFormat from superset.common.db_query_status import QueryStatus from superset.constants import NULL_STRING from superset.errors import ErrorLevel, SupersetError, SupersetErrorType @@ -77,7 +76,7 @@ VizData, VizPayload, ) -from superset.utils import core as utils, csv, excel +from superset.utils import core as utils, csv from superset.utils.cache import set_and_log_cache from superset.utils.core import ( apply_max_row_limit, @@ -671,13 +670,6 @@ def get_csv(self) -> Optional[str]: include_index = not isinstance(df.index, pd.RangeIndex) return csv.df_to_escaped_csv(df, index=include_index, **config["CSV_EXPORT"]) - def get_excel(self, excel_format: ChartDataResultFormat) -> Optional[bytes]: - df = self.get_df_payload()["df"] - include_index = not isinstance(df.index, pd.RangeIndex) - return excel.df_to_excel( - df, index=include_index, excel_format=excel_format, **config["EXCEL_EXPORT"] - ) - def get_data(self, df: pd.DataFrame) -> VizData: # pylint: disable=no-self-use return df.to_dict(orient="records")