From 474e2f0aa81faf251461d0a9d7f12020cf9caebf Mon Sep 17 00:00:00 2001
From: Rajan Gupta <rajan0493@gmail.com>
Date: Wed, 18 Jan 2023 15:03:50 +0800
Subject: [PATCH] address review comments

---
 helm/superset/templates/service.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/helm/superset/templates/service.yaml b/helm/superset/templates/service.yaml
index ee32b04cf2666..97db594a23958 100644
--- a/helm/superset/templates/service.yaml
+++ b/helm/superset/templates/service.yaml
@@ -35,7 +35,7 @@ spec:
       targetPort: http
       protocol: TCP
       name: http
-      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (nil .Values.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (empty .Values.service.nodePort.http)) }}
       nodePort: {{ .Values.service.nodePort.http }}
       {{- end }}
   selector:
@@ -67,7 +67,7 @@ spec:
       targetPort: flower
       protocol: TCP
       name: flower
-      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (nil .Values.supersetCeleryFlower.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (empty .Values.supersetCeleryFlower.service.nodePort.http)) }}
       nodePort: {{ .Values.supersetCeleryFlower.service.nodePort.http }}
       {{- end }}
   selector:
@@ -100,7 +100,7 @@ spec:
       targetPort: ws
       protocol: TCP
       name: ws
-      {{- if and (or (eq .Values.supersetWebsockets.service.type "NodePort") (eq .Values.supersetWebsockets.service.type "LoadBalancer")) (not (nil .Values.supersetWebsockets.service.nodePort.http)) }}
+      {{- if and (or (eq .Values.supersetWebsockets.service.type "NodePort") (eq .Values.supersetWebsockets.service.type "LoadBalancer")) (not (empty .Values.supersetWebsockets.service.nodePort.http)) }}
       nodePort: {{ .Values.supersetWebsockets.service.nodePort.http }}
       {{- end }}
   selector: