From 3272d1c0867fd746f083d2cced692e1603eaf42c Mon Sep 17 00:00:00 2001 From: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Date: Wed, 29 Sep 2021 17:30:41 +0200 Subject: [PATCH] fix(sqla): allow series limit without subquery support (#16896) --- superset/connectors/sqla/models.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 7cebb8bac7c16..a27a4a1631e25 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -1292,8 +1292,8 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma if row_offset: qry = qry.offset(row_offset) - if db_engine_spec.allows_subqueries and series_limit and groupby_series_columns: - if db_engine_spec.allows_joins: + if series_limit and groupby_series_columns: + if db_engine_spec.allows_joins and db_engine_spec.allows_subqueries: # some sql dialects require for order by expressions # to also be in the select clause -- others, e.g. vertica, # require a unique inner alias