Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44513][BUILD][3.4] Upgrade snappy-java to 1.1.10.3 #42127

Closed

Conversation

panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

  • The pr is for branch-3.4.
  • The pr aims to upgrade snappy-java from 1.1.10.2 to 1.1.10.3.

Why are the changes needed?

1.The newest version include a bug fixed:

2.Release notes:
https://github.com/xerial/snappy-java/releases/tag/v1.1.10.3

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@github-actions github-actions bot added the BUILD label Jul 24, 2023
@panbingkun
Copy link
Contributor Author

@LuciferYang

@panbingkun panbingkun changed the title [SPARK-44513][BUILD] Upgrade snappy-java to 1.1.10.3 [SPARK-44513][BUILD][3.4] Upgrade snappy-java to 1.1.10.3 Jul 24, 2023
@panbingkun
Copy link
Contributor Author

cc @wangyum

@dongjoon-hyun
Copy link
Member

Could you re-run the failed test pipelines, @panbingkun ?

@panbingkun
Copy link
Contributor Author

Could you re-run the failed test pipelines, @panbingkun ?

Done, let's waiting CI.

@panbingkun
Copy link
Contributor Author

@LuciferYang
Copy link
Contributor

@LuciferYang
Copy link
Contributor

@LuciferYang Do we need to backport #42091 to branch-3.4 https://github.com/panbingkun/spark/actions/runs/5643752423/job/15345611131 image

#42162

@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 26, 2023

Python code generation check failed too

image

@panbingkun
Copy link
Contributor Author

Python code generation check failed too

image

@dongjoon-hyun @HyukjinKwon @LuciferYang @wangyum
To resolve the above issues, do we need to backport #41933 to branch-3.4?

@LuciferYang
Copy link
Contributor

Can we just skip the check of Python code generation check in branch-3.4?

@HyukjinKwon
Copy link
Member

yeah, I think so

@panbingkun
Copy link
Contributor Author

Ignoring connect-check-protos logic in GA testing for branch-3.4
#42166

@panbingkun
Copy link
Contributor Author

The GA finally turned green.

wangyum pushed a commit that referenced this pull request Jul 27, 2023
### What changes were proposed in this pull request?
- The pr is for branch-3.4.
- The pr aims to upgrade snappy-java from  1.1.10.2 to 1.1.10.3.

### Why are the changes needed?
1.The newest version include a bug fixed:
- Fix the GLIBC_2.32 not found issue of libsnappyjava.so in certain Linux distributions on s390x by kun-lu20 in xerial/snappy-java#481

2.Release notes:
https://github.com/xerial/snappy-java/releases/tag/v1.1.10.3

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes #42127 from panbingkun/branch-3.4_snappy_1_1_10_3.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
@wangyum
Copy link
Member

wangyum commented Jul 27, 2023

Thanks. Merged to branch-3.4.

@wangyum wangyum closed this Jul 27, 2023
viirya pushed a commit to viirya/spark-1 that referenced this pull request Oct 19, 2023
### What changes were proposed in this pull request?
- The pr is for branch-3.4.
- The pr aims to upgrade snappy-java from  1.1.10.2 to 1.1.10.3.

### Why are the changes needed?
1.The newest version include a bug fixed:
- Fix the GLIBC_2.32 not found issue of libsnappyjava.so in certain Linux distributions on s390x by kun-lu20 in xerial/snappy-java#481

2.Release notes:
https://github.com/xerial/snappy-java/releases/tag/v1.1.10.3

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes apache#42127 from panbingkun/branch-3.4_snappy_1_1_10_3.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants