Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] skywalking-eyes: dep check failed when dependencies support multi license? #9319

Closed
3 tasks done
jmjoy opened this issue Jul 6, 2022 · 0 comments · Fixed by apache/skywalking-eyes#120
Closed
3 tasks done
Assignees
Labels
bug Something isn't working and you are sure it's a bug!

Comments

@jmjoy
Copy link
Member

jmjoy commented Jul 6, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

License Tools (apache/skywalking-eyes)

What happened

For example, the license of my Go project is Apache-2.0, I add the mod github.com/ericlagergren/go-coreutils to the project, the license of this mod is GPL-3.0 and GPL-3.0-or-later, In theory Apache-2.0 and GPL-3.0 are incompatible, but dep check passed.

What you expected to happen

dep check failed.

How to reproduce

Just run go get github.com/ericlagergren/go-coreutils in skywalking-eyes, and run license-eye dep check.

Anything else

Maybe the code https://github.com/apache/skywalking-eyes/blob/f461a46e74e5fa22e9f9599a355ab4f0ac265469/pkg/deps/check.go#L67 only compare license string with == rather than handling the AND, OR keywords.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@jmjoy jmjoy added the bug Something isn't working and you are sure it's a bug! label Jul 6, 2022
@wu-sheng wu-sheng added this to the license-eye 0.4.0 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants