[Bug] skywalking-eyes: dep check failed when dependencies support multi license? #9319
Closed
3 tasks done
Labels
bug
Something isn't working and you are sure it's a bug!
Milestone
Search before asking
Apache SkyWalking Component
License Tools (apache/skywalking-eyes)
What happened
For example, the license of my Go project is
Apache-2.0
, I add the mod github.com/ericlagergren/go-coreutils to the project, the license of this mod isGPL-3.0 and GPL-3.0-or-later
, In theoryApache-2.0
andGPL-3.0
are incompatible, butdep check
passed.What you expected to happen
dep check failed.
How to reproduce
Just run
go get github.com/ericlagergren/go-coreutils
inskywalking-eyes
, and runlicense-eye dep check
.Anything else
Maybe the code https://github.com/apache/skywalking-eyes/blob/f461a46e74e5fa22e9f9599a355ab4f0ac265469/pkg/deps/check.go#L67 only compare license string with
==
rather than handling theAND
,OR
keywords.Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: