Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[License-Eye] pyx files (cython) #7552

Closed
1 of 4 tasks
keiranmraine opened this issue Aug 24, 2021 · 9 comments
Closed
1 of 4 tasks

[License-Eye] pyx files (cython) #7552

keiranmraine opened this issue Aug 24, 2021 · 9 comments
Assignees

Comments

@keiranmraine
Copy link

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

Please can one or more of the following be added to the sykwalking-eyes functionality (or expansion of docs if already available):

  • Runtime extensions equivalence via CLI (py=~pyx)
  • Ability to define extension equivalence in the .licenserc.yaml
  • Add common cython file extentions to core.
@kezhenxu94 kezhenxu94 changed the title pyx files (cython) [License-Eye] pyx files (cython) Aug 24, 2021
@kezhenxu94 kezhenxu94 added enhancement Enhancement on performance or codes license eye labels Aug 24, 2021
@wu-sheng wu-sheng removed the enhancement Enhancement on performance or codes label Aug 24, 2021
@kezhenxu94 kezhenxu94 added this to the license-eye 0.2.0 milestone Aug 24, 2021
@kezhenxu94
Copy link
Member

@keiranmraine can you read https://github.com/apache/skywalking-eyes#supported-file-types and try to contribute to this enhancement?

@keiranmraine
Copy link
Author

keiranmraine commented Aug 25, 2021

According to the current main branch the .pyx extension is supported:

https://github.com/apache/skywalking-eyes/blob/082ccc7d63f8cde9afdb6eee30843b8f0a8182ed/assets/languages.yaml#L1090

It appears that although it works for check it fails for `fix:

check - identifies file needs update:

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
...
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0 
ERROR the following files don't have a valid license header: 
pygas/matrix.pyx 

fix - indicates unsupported:

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
INFO Totally checked 138 files, valid: 13, invalid: 1, ignored: 124, fixed: 0 
ERROR unsupported file: pygas/matrix.pyx

@keiranmraine
Copy link
Author

Repo/file in example can be found here:
https://github.com/cancerit/pygas/blob/develop/pygas/matrix.pyx

@kezhenxu94
Copy link
Member

@keiranmraine yes, check is generally available for most (if not all) programming languages, but fix need to know what's the comment style of a specific language.

@keiranmraine
Copy link
Author

Ah, okay so it needs a section like the Python one creating for Cython. I'll look at it.

@keiranmraine
Copy link
Author

FYI if you find people are unable to build the docker file this will solve the problem for them:

https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2

Created: apache/skywalking-eyes#62

@kezhenxu94
Copy link
Member

FYI if you find people are unable to build the docker file this will solve the problem for them:

https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2

Created: apache/skywalking-eyes#62

Thanks for the information.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 3, 2021

@kezhenxu94 Is this done?

@kezhenxu94
Copy link
Member

@kezhenxu94 Is this done?

Fixed by apache/skywalking-eyes#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants