Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1172, for comments #1253

Merged
merged 116 commits into from
Sep 14, 2018
Merged

#1172, for comments #1253

merged 116 commits into from
Sep 14, 2018

Conversation

tuohai666
Copy link
Member

Fixes #1172.

@coveralls
Copy link

coveralls commented Sep 12, 2018

Pull Request Test Coverage Report for Build 5066

  • 55 of 91 (60.44%) changed or added relevant lines in 11 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.0009%) to 63.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/src/main/java/io/shardingsphere/core/routing/router/sharding/ParsingSQLRouter.java 4 5 80.0%
sharding-opentracing/src/main/java/io/shardingsphere/opentracing/listener/SQLExecuteEventListener.java 13 15 86.67%
sharding-opentracing/src/main/java/io/shardingsphere/opentracing/listener/RootInvokeEventListener.java 6 9 66.67%
sharding-jdbc/src/main/java/io/shardingsphere/core/jdbc/adapter/AbstractConnectionAdapter.java 20 23 86.96%
sharding-opentracing/src/main/java/io/shardingsphere/opentracing/listener/GetConnectionEventListener.java 0 7 0.0%
sharding-opentracing/src/main/java/io/shardingsphere/opentracing/listener/CloseConnectionEventListener.java 0 8 0.0%
sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteCallback.java 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-reg/src/main/java/io/shardingsphere/orchestration/reg/newzk/client/zookeeper/base/Holder.java 1 70.49%
sharding-core/src/main/java/io/shardingsphere/core/executor/sql/execute/SQLExecuteCallback.java 1 0.0%
sharding-opentracing/src/main/java/io/shardingsphere/opentracing/listener/GetConnectionEventListener.java 3 0.0%
Totals Coverage Status
Change from base Build 5062: -0.0009%
Covered Lines: 7961
Relevant Lines: 12629

💛 - Coveralls

@terrymanu terrymanu merged commit cc52f22 into apache:dev Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants