Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA_NODE_SUFFIX_PATTERN's changes from 5.21 to 5.4.1 #32792

Closed
LeavesGirl opened this issue Sep 4, 2024 · 4 comments
Closed

DATA_NODE_SUFFIX_PATTERN's changes from 5.21 to 5.4.1 #32792

LeavesGirl opened this issue Sep 4, 2024 · 4 comments

Comments

@LeavesGirl
Copy link

Bug Report

TableRule's prop DATA_NODE_SUFFIX_PATTERN changed from 5.2.1【 (\d+[-]){0,}(\d+$) 】to 5.4.1 【\d+$】,
our table used name like【 t_order_2023_01,t_order_2024_01,t_order_item_2023_01,t_order_item_2024_01】,we used time to split ,when we changed the sharding-jdbc version to 5.4.1,the bindingtables validator maked error,it parse the prefix with 't_order_2023
',I saw the issues about DATA_NODE_SUFFIX_PATTERN's changes, why delete the prop actualTablePrefix, if it still existed, I could point it ,but now ,this prop with private final modifiers,I cant change it,

Before report a bug, make sure you have:

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Which version of ShardingSphere did you use?

5.4.1

Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?

ShardingSphere-JDBC

Expected behavior

suport table names like t_order_2023_01,t_order_2024_01,t_order_item_2023_01,t_order_item_2024_01

Actual behavior

when bindings t_order_2023_01,t_order_2024_01,t_order_item_2023_01,t_order_item_2024_01

Caused by: org.apache.shardingsphere.sharding.exception.metadata.InvalidBindingTablesException: Invalid binding table configuration in ShardingRuleConfiguration.

Reason analyze (If you can)

Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.

Example codes for reproduce this issue (such as a github link).

@terrymanu
Copy link
Member

What is TableRule?

@LeavesGirl
Copy link
Author

What is TableRule?

org.apache.shardingsphere.sharding.rule.TableRule#DATA_NODE_SUFFIX_PATTERN

@terrymanu
Copy link
Member

This class is changed in the lasted version, can you try the new version?

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants