Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code conduct] There are a lot of indents in the g4 files that shouldn't be there #31892

Closed
RaigorJiang opened this issue Jun 27, 2024 · 4 comments · Fixed by #32779
Closed

[code conduct] There are a lot of indents in the g4 files that shouldn't be there #31892

RaigorJiang opened this issue Jun 27, 2024 · 4 comments · Fixed by #32779
Assignees
@elysium-w
Labels
good first issue type: refactor

Comments

@RaigorJiang
Copy link
Contributor

According to Parser Conduct, blank line should have no indents
https://shardingsphere.apache.org/community/en/involved/conduct/code/#contributor-covenant-g4-of-conduct

shardingsphere-parser-sql-mysql

image

shardingsphere-parser-sql-hive

image
@elysium-w
Copy link

@RaigorJiang I will finish it.

@RaigorJiang
Copy link
Contributor Author

Assigned, thank you @elysium-w

@elysium-w
Copy link

Assigned, thank you @elysium-w

which branch should I submit this work to?

@RaigorJiang
Copy link
Contributor Author

@elysium-w Please submit a PR for master, thank you!
https://shardingsphere.apache.org/community/en/involved/contribute/contributor/

Arshveer439 added a commit to Arshveer439/shardingsphere that referenced this issue Sep 3, 2024
@Arshveer439
apache#31892 Refactor: Removed redundant indents from g4 files.
613d958
@Arshveer439 Arshveer439 mentioned this issue Sep 3, 2024
Merged
linghengqian pushed a commit that referenced this issue Sep 9, 2024
@Arshveer439
#31892 Refactor: Removed redundant indents from g4 files. (#32779)
1a0804e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elysium-w elysium-w

Labels
good first issue type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#31892 Refactor: Removed redundant indents from g4 files. Arshveer439/shardingsphere
2 participants
@RaigorJiang @elysium-w