Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shardingsphere-agent should have a more convenient distribution method #32777

Closed
linghengqian opened this issue Sep 2, 2024 · 6 comments · Fixed by #32945
Closed

shardingsphere-agent should have a more convenient distribution method #32777

linghengqian opened this issue Sep 2, 2024 · 6 comments · Fixed by #32945
Assignees
Labels

Comments

@linghengqian
Copy link
Member

linghengqian commented Sep 2, 2024

Feature Request

For English only, other languages will not be accepted.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

  • No.

Describe the feature you would like.

sdk install java 22.0.2-graalce
sdk install maven 3.9.9
mvn clean dependency:get -Dartifact=org.apache.shardingsphere:shardingsphere-agent:5.5.0
COPY --from=apache/shardingsphere-agent:5.5.0 /apache-shardingsphere-5.5.0-shardingsphere-agent-bin ./apache-shardingsphere-agent/
@linghengqian linghengqian changed the title Why is the shardingsphere-agent JAR not published to Maven Central? shardingsphere-agent should have a more convenient distribution method Sep 2, 2024
@jiangML
Copy link
Contributor

jiangML commented Sep 4, 2024

@linghengqian Hi,
I think this is unnecessary, because shardingsphere-agent and shardingsphere-proxyare strongly related. And the shardingsphere-proxy artifact already contains the shardingsphere-agent.

Can download it from the official website address https://shardingsphere.apache.org/document/current/en/downloads/

@jiangML jiangML added the feature: agent shardingsphere agent label Sep 4, 2024
@linghengqian
Copy link
Member Author

@linghengqian Hi, I think this is unnecessary, because shardingsphere-agent and shardingsphere-proxyare strongly related. And the shardingsphere-proxy artifact already contains the shardingsphere-agent.

Can download it from the official website address https://shardingsphere.apache.org/document/current/en/downloads/

FROM alpine AS prepare
# `APP_NAME` will be dynamically set to `apache-shardingsphere-5.5.1-SNAPSHOT-shardingsphere-agent-bin` from `distribution/agent/pom.xml`
ARG APP_NAME
ADD target/${APP_NAME}.tar.gz /opt
RUN mv /opt/${APP_NAME} /opt/shardingsphere-agent

FROM eclipse-temurin:22-jdk
MAINTAINER ShardingSphere "dev@shardingsphere.apache.org"
ENV LOCAL_PATH /opt/shardingsphere-agent
COPY --from=prepare /opt/shardingsphere-agent /opt/shardingsphere-agent

@jiangML
Copy link
Contributor

jiangML commented Sep 9, 2024

@linghengqian Hi, I think this is unnecessary, because shardingsphere-agent and shardingsphere-proxyare strongly related. And the shardingsphere-proxy artifact already contains the shardingsphere-agent.
Can download it from the official website address https://shardingsphere.apache.org/document/current/en/downloads/

FROM alpine AS prepare
# `APP_NAME` will be dynamically set to `apache-shardingsphere-5.5.1-SNAPSHOT-shardingsphere-agent-bin` from `distribution/agent/pom.xml`
ARG APP_NAME
ADD target/${APP_NAME}.tar.gz /opt
RUN mv /opt/${APP_NAME} /opt/shardingsphere-agent

FROM eclipse-temurin:22-jdk
MAINTAINER ShardingSphere "dev@shardingsphere.apache.org"
ENV LOCAL_PATH /opt/shardingsphere-agent
COPY --from=prepare /opt/shardingsphere-agent /opt/shardingsphere-agent

Can you try to implement it?

@linghengqian
Copy link
Member Author

Can you try to implement it?

  • I will submit a PR in the near future to show a prototype Docker Image.

@linghengqian
Copy link
Member Author

  • I am waiting for the CI execution of the nightly build to further perform external integration tests.

@linghengqian
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants