for #1172, remove useless updateSpan

apache · Sep 25, 2018 · e3a6645 · e3a6645
1 parent ada370d
commit e3a6645
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 21 deletions.
diff --git a/...c/main/java/io/shardingsphere/opentracing/handler/tracing/OpenTracingHandlerTemplate.java b/...c/main/java/io/shardingsphere/opentracing/handler/tracing/OpenTracingHandlerTemplate.java
@@ -63,7 +63,6 @@ private SpanBuilder createSpanBuilder() {
     }
 
     private void tracingFinish(final OpenTracingSpanFinishCallback spanFinishCallback) {
-        spanFinishCallback.updateSpan(spanHolder.get());
         spanHolder.get().finish();
         spanHolder.remove();
         spanFinishCallback.afterTracingFinish();

diff --git a/...ain/java/io/shardingsphere/opentracing/handler/tracing/OpenTracingSpanFinishCallback.java b/...ain/java/io/shardingsphere/opentracing/handler/tracing/OpenTracingSpanFinishCallback.java
@@ -17,22 +17,13 @@
 
 package io.shardingsphere.opentracing.handler.tracing;
 
-import io.opentracing.Span;
-
 /**
  * Open tracing span finish callback.
  *
  * @author zhangliang
  */
 public interface OpenTracingSpanFinishCallback {
 
-    /**
-     * Update span.
-     * 
-     * @param span span to be updated.
-     */
-    void updateSpan(Span span);
-
     /**
      * Hook after tracing finished.
      */

diff --git a/...a/io/shardingsphere/opentracing/handler/tracing/OpenTracingSpanFinishCallbackAdapter.java b/...a/io/shardingsphere/opentracing/handler/tracing/OpenTracingSpanFinishCallbackAdapter.java
@@ -17,19 +17,13 @@
 
 package io.shardingsphere.opentracing.handler.tracing;
 
-import io.opentracing.Span;
-
 /**
  * Open tracing span finish callback adapter.
  *
  * @author zhangliang
  */
 public class OpenTracingSpanFinishCallbackAdapter implements OpenTracingSpanFinishCallback {
 
-    @Override
-    public void updateSpan(final Span span) {
-    }
-
     @Override
     public void afterTracingFinish() {
     }

diff --git a/...dingsphere/opentracing/handler/tracing/OpenTracingSpanFinishRootCleanCallbackAdapter.java b/...dingsphere/opentracing/handler/tracing/OpenTracingSpanFinishRootCleanCallbackAdapter.java
@@ -17,7 +17,6 @@
 
 package io.shardingsphere.opentracing.handler.tracing;
 
-import io.opentracing.Span;
 import io.shardingsphere.opentracing.handler.root.OpenTracingRootInvokeHandler;
 import lombok.RequiredArgsConstructor;
 
@@ -31,10 +30,6 @@ public class OpenTracingSpanFinishRootCleanCallbackAdapter implements OpenTracin
 
     private final boolean isTrunkThread;
 
-    @Override
-    public void updateSpan(final Span span) {
-    }
-
     @Override
     public final void afterTracingFinish() {
         if (!isTrunkThread) {